Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nifinodegroupenabling #439

Merged
merged 12 commits into from
Sep 6, 2024
Merged

Feature/nifinodegroupenabling #439

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
604117a
Replicas handling for nifi autoscaling enabling
aswathinj-pai Jul 5, 2024
6248bc8
Changes to nodeGroupAutoscalers
aswathinj-pai Jul 5, 2024
9c48729
Merge branch 'master' into feature/nifinodegroupenabling
juldrixx Jul 6, 2024
af51ce7
Merge branch 'master' into feature/nifinodegroupenabling
juldrixx Jul 6, 2024
575ce1a
Merge branch 'master' into feature/nifinodegroupenabling
juldrixx Sep 2, 2024
cdccf73
Update CHANGELOG.md
aswathinj-pai Sep 6, 2024
21cad10
Update helm/nifi-cluster/values.yaml
aswathinj-pai Sep 6, 2024
d972f63
Update CHANGELOG.md
aswathinj-pai Sep 6, 2024
c1d29a3
Update helm/nifi-cluster/templates/nifi-node-group-autoscaler.yaml
aswathinj-pai Sep 6, 2024
bf44e31
Merge branch 'master' into feature/nifinodegroupenabling
aswathinj-pai Sep 6, 2024
c87fc0e
Update CHANGELOG.md
aswathinj-pai Sep 6, 2024
511ccb9
Update CHANGELOG.md
aswathinj-pai Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@

### Fixed Bugs


- [PR #439](https://github.com/konpyutaika/nifikop/pull/439) - **[Operator]** Handling the replicas attribute in the nifinodegroupautoscaler template in nifi-cluster helm chart.
aswathinj-pai marked this conversation as resolved.
Show resolved Hide resolved
aswathinj-pai marked this conversation as resolved.
Show resolved Hide resolved
- [PR #451](https://github.com/konpyutaika/nifikop/pull/451) - **[Operator]** Fixed `nil pointer dereference` that occurred when logging failures without an underlying error.


aswathinj-pai marked this conversation as resolved.
Show resolved Hide resolved
### Deprecated

### Removed
Expand Down
3 changes: 3 additions & 0 deletions helm/nifi-cluster/templates/nifi-node-group-autoscaler.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ spec:
{{ end }}
upscaleStrategy: {{ .upscaleStrategy }}
downscaleStrategy: {{ .downscaleStrategy }}
{{ if .replicas }}
replicas: {{ .replicas }}
{{ end }}
{{ end }}
{{ end }}
{{ end }}
1 change: 1 addition & 0 deletions helm/nifi-cluster/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ nodeGroupAutoscalers:
default-scale-group: "true"
upscaleStrategy: simple
downscaleStrategy: lifo
replicas: ~
# this is the horizontal pod autoscaler spec: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/
# you may include both metrics and behavior here.
horizontalAutoscaler:
Expand Down