Feature/nifinodegroupenabling #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
approved these changes
Sep 5, 2024
|
@aswathinj-pai : Can you please just update the |
|
Updated the changelog @mh013370 |
juldrixx
requested changes
Sep 6, 2024
|
And can you fix the conflicts? |
Co-authored-by: Juldrixx <[email protected]>
Co-authored-by: Juldrixx <[email protected]>
Co-authored-by: Juldrixx <[email protected]>
|
@juldrixx conflict resolved. |
juldrixx
requested changes
Sep 6, 2024
Co-authored-by: Juldrixx <[email protected]>
Co-authored-by: Juldrixx <[email protected]>
juldrixx
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The current helm chart doesn't handle the replicas attribute in the nifinodegroupautoscaler template in nifi-cluster helm chart. Consequently, it defaults to 0, disabling the HPA created alongside it and preventing autoscaling. Therefore, to enable this feature, we need to manage the replicas attribute in the nifi-node-group-autoscaler.yaml template.
Checklist
To Do