Expose nifi pod readiness and liveness probes in nifi-cluster helm chart #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
changed the title
r65535
reviewed
Jan 16, 2024
juldrixx
approved these changes
Jan 22, 2024
|
I think it's good to merge. Just need to resolve the conflicts. right? @mh013370 |
Agree. I will resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds the existing
NifiCluster.Spec.Pod.ReadinessProbeandNifiCluster.Spec.Pod.LivenessProbeconfiguration to the nifi-cluster helm chart.Why?
This was overlooked when the chart was created.
Checklist