Skip to content

Commit

Permalink
Expose nifi pod readiness and liveness probes in nifi-cluster helm ch…
Browse files Browse the repository at this point in the history
…art (#364)

* expose nifi pod readiness and liveness config in nifi-cluster helm chart

* update changelog

* fix typo
  • Loading branch information
mh013370 authored Jan 23, 2024
1 parent 589f460 commit bbe54e0
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@

### Added

- [PR #345](https://github.com/konpyutaika/nifikop/pull/345) - **[Helm Chart]** Added option to include `NodePort` with custom hosts in `webProxyHosts`.
- [PR #364](https://github.com/konpyutaika/nifikop/pull/364) - **[Helm Chart]** Added ability to configure NiFi Pod `ReadinessProbe` and `LivenessProbe` in the nifi-cluster chart.
- [PR #367](https://github.com/konpyutaika/nifikop/pull/367) - **[Operator/NifiParameterContext]** Parameter context's secret update detection.

### Changed

- [PR #340](https://github.com/konpyutaika/nifikop/pull/340) - **[Operator/NifiDataflow]** Updated the logic to stop the entire dataflow instead of just the processors when the parameter context reference is updated.
- [PR #342](https://github.com/konpyutaika/nifikop/pull/342) - **[Operator/NifiCluster]** Updated the logic to retrieve theIP address from hostname with `curl` instead of `wget`.
- [PR #341](https://github.com/konpyutaika/nifikop/pull/341) - **[Helm Chart]** Fixed `webProxyHosts` conversion to Yaml. Updated zookeeper dependency. Updated `ServiceMonitor` endpoints generation.
- [PR #345](https://github.com/konpyutaika/nifikop/pull/345) - **[Helm Chart]** Added option to include `NodePort` with custom hosts in `webProxyHosts`.
- [PR #349](https://github.com/konpyutaika/nifikop/pull/349) - **[Operator/NifiRegistryClient]** Set FlowRegistry type in RegistryClient creation.
- [PR #350](https://github.com/konpyutaika/nifikop/pull/350) - **[Operator]** Remove optimistic lock on `Patch`.
- [PR #352](https://github.com/konpyutaika/nifikop/pull/352) - **[Operator]** Changed default LogLevel of NiFi from `DEBUG` to `INFO`.
Expand Down
2 changes: 2 additions & 0 deletions helm/nifi-cluster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ A Helm chart for deploying NiFi clusters in Kubernetes
| cluster.pod.annotations | object | `{}` | Annotations to apply to every pod |
| cluster.pod.hostAliases | list | `[]` | host aliases to assign to each pod. See: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#hostalias-v1-core |
| cluster.pod.labels | object | `{}` | Labels to apply to every pod |
| cluster.pod.livenessProbe | object | `nil` | The pod liveness probe override: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-liveness-command |
| cluster.pod.readinessProbe | object | `nil` | The pod readiness probe override: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-readiness-probes |
| cluster.propagateLabels | bool | `true` | |
| cluster.retryDurationMinutes | int | `10` | The number of minutes the operator should wait for the cluster to be successfully deployed before retrying |
| cluster.service.annotations | object | `{}` | Annotations to apply to each nifi service |
Expand Down
8 changes: 8 additions & 0 deletions helm/nifi-cluster/templates/nifi-cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ spec:
hostAliases:
{{- toYaml .Values.cluster.pod.hostAliases | nindent 6}}
{{- end }}
{{- if .Values.cluster.pod.livenessProbe -}}
livenessProbe:
{{- toYaml .Values.cluster.pod.livenessProbe | nindent 6}}
{{- end -}}
{{- if .Values.cluster.pod.readinessProbe -}}
readinessProbe:
{{- toYaml .Values.cluster.pod.readinessProbe | nindent 6}}
{{- end -}}
singleUserConfiguration:
{{- if .Values.cluster.singleUserConfiguration.enabled }}
enabled: {{ .Values.cluster.singleUserConfiguration.enabled }}
Expand Down
4 changes: 4 additions & 0 deletions helm/nifi-cluster/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ cluster:
labels: {}
# -- host aliases to assign to each pod. See: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#hostalias-v1-core
hostAliases: []
# -- (object) The pod readiness probe override: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-readiness-probes
readinessProbe:
# -- (object) The pod liveness probe override: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-liveness-command
livenessProbe:

image:
repository: "apache/nifi"
Expand Down

0 comments on commit bbe54e0

Please sign in to comment.