fix(verify-source): return results without trailing newlines#2875
Merged
arewm merged 1 commit intoMar 4, 2026
Conversation
Modify Task to write results using printf instead of echo to avoid trailing newlines. Update tests to expect newline-less results instead of stripping them. Addresses review comment from PR konflux-ci#2867. Assisted-by: Claude Code Signed-off-by: Ralph Bean <rbean@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the review comment from PR #2867: "Consider not removing the newline here - I think we want the Task to return results without trailing newlines and the test should verify that"
This PR modifies the
verify-sourcetask to write results without trailing newlines and updates both test files to expect this behavior.Changes
verify-source.yaml): Changed fromechotoprintf '%s'when writing results to avoid appending trailing newlinestr -d '\n'logic that was stripping newlines, since the Task now returns clean resultstest-verify-source-with-vsa.yamltest-verify-source-no-vsa.yamlTesting
Related
Generated with assistance from Claude Code