Revert prettier code-formatting #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dited file which invalidates git blame history for line-by-line changes
Member
|
It'd be great to have a tool like Prettier that operates only on changed lines, but alas... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1778.
Prettier's pre-commit hook makes formatting changes to whole files (as soon as anything on the file is edited). That means that we would quickly lose the line-by-line
git blamehistory (or make it extremely complicated to access).After discussions with John, we decided to revert Prettier. We may revisit this in the future, but we would certainly look for something that's less drastic.