Skip to content

Conversation

@magicznyleszek
Copy link
Member

@pmusaraj I already have prettier installed as a plugin in my editor. The plugin has an option to apply prettier on saving file, and it worked great for me since I started using it. Now I see the prettier folk recommend adding a precommit script that prettify staged files - do you think we would like to try that, or better to have some control on the commits?

@magicznyleszek magicznyleszek added the workflow Related to development process label May 14, 2018
@magicznyleszek magicznyleszek requested a review from pmusaraj May 14, 2018 18:21
@pmusaraj
Copy link
Contributor

Yes, let's try the precommit script.

@magicznyleszek
Copy link
Member Author

@pmusaraj I've found out you can have .prettierignore so it will not fix automatically some files (like package.json for example. I've added what I think should be there, but feel free to improve it :)

@pmusaraj pmusaraj merged commit 6d27e3b into master May 16, 2018
@pmusaraj pmusaraj deleted the feature/prettier branch May 16, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow Related to development process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants