Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: not enforce KO_DOCKER_REPO with push=false #604

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Feb 20, 2022

Hi everyone,

This PR fixes #590 and was good for me to get used with the codebase of ko.

@codecov-commenter
Copy link

Codecov Report

Merging #604 (21e76c3) into main (eb2597f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   48.51%   48.51%           
=======================================
  Files          43       43           
  Lines        2259     2259           
=======================================
  Hits         1096     1096           
  Misses        978      978           
  Partials      185      185           
Impacted Files Coverage Δ
pkg/commands/resolver.go 30.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2597f...21e76c3. Read the comment docs.

@imjasonh
Copy link
Member

Nice! Thanks for this contribution!

@imjasonh imjasonh merged commit 921a580 into ko-build:main Feb 20, 2022
@dirien dirien deleted the push_false branch February 20, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ux: consider do not enforce KO_DOCKER_REPO variable if --push=false
3 participants