Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ux: consider do not enforce KO_DOCKER_REPO variable if --push=false #590

Closed
Dentrax opened this issue Feb 10, 2022 · 1 comment · Fixed by #604
Closed

ux: consider do not enforce KO_DOCKER_REPO variable if --push=false #590

Dentrax opened this issue Feb 10, 2022 · 1 comment · Fixed by #604
Labels
good first issue Good for newcomers

Comments

@Dentrax
Copy link

Dentrax commented Feb 10, 2022 •
edited
Loading

Since we can pass --push=false, in this case $KO_DOCKER_REPO env flag could be useless to check whether it's set or not. It should be only checked if we're pushing image to remote. Wdyt?

$ ko publish --bare -B --platform=linux/amd64 --tags latest --push=false --oci-layout-path oci-dir .
Error: error creating publisher: KO_DOCKER_REPO environment variable is unset
2022/02/10 10:01:55 error during command execution:error creating publisher: KO_DOCKER_REPO environment variable is unset
@imjasonh imjasonh added the good first issue Good for newcomers label Feb 10, 2022
@dirien dirien mentioned this issue Feb 20, 2022
Merged
@dirien
Copy link
Contributor

dirien commented Feb 20, 2022

Created a PR for this #604, was good to get used with the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: not enforce KO_DOCKER_REPO with push=false dirien/ko
3 participants
@imjasonh @Dentrax @dirien