Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce more lint checks, fix findings #492

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Nov 5, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #492 (9d71b16) into main (9821190) will decrease coverage by 0.02%.
The diff coverage is 33.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   50.17%   50.15%   -0.03%     
==========================================
  Files          41       41              
  Lines        1945     1944       -1     
==========================================
- Hits          976      975       -1     
  Misses        809      809              
  Partials      160      160              
Impacted Files Coverage Δ
pkg/build/gobuilds.go 72.54% <0.00%> (ø)
pkg/commands/apply.go 51.35% <0.00%> (ø)
pkg/commands/build.go 68.75% <0.00%> (ø)
pkg/commands/config.go 56.14% <0.00%> (ø)
pkg/commands/create.go 47.43% <0.00%> (ø)
pkg/commands/deps.go 17.24% <0.00%> (ø)
pkg/commands/options/build.go 50.00% <0.00%> (ø)
pkg/commands/publisher.go 46.66% <0.00%> (ø)
pkg/commands/resolve.go 74.41% <0.00%> (ø)
pkg/commands/run.go 26.76% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9821190...9d71b16. Read the comment docs.

Copy link
Collaborator

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question, and there's a CodeQL thing we should look at, but otherwise 👍

thanks for the cleanup 🙏

@mattmoor mattmoor merged commit 0015a81 into ko-build:main Nov 5, 2021
@imjasonh
Copy link
Member Author

imjasonh commented Nov 5, 2021

A question, and there's a CodeQL thing we should look at, but otherwise 👍

The CodeQL alert was supposed to be fixed by #459, I think this is some regression in CodeQL that it considers this an error again. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants