Add e2e test for using ldflags to set a build-time variable (#480)

ko-build · Nov 2, 2021 · 9821190 · 9821190
1 parent 17edbb3
commit 9821190
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -49,3 +49,14 @@ jobs:
         if [[ "$RUNNER_OS" == "Linux" ]]; then
           docker run ${testimg} --wait=false -f HEAD
         fi
+
+        # Check that using ldflags to set variables works.
+        cat > .ko.yaml << EOF
+        builds:
+        - id: test
+          main: ./test/
+          ldflags:
+          - "-X main.version=${{ github.sha }}"
+        EOF
+        docker run $(go run ./ publish ./test/ --platform=${GOOS}/${GOARCH}) --wait=false 2>&1 | grep "${{ github.sha }}"
+
diff --git a/.ko.yaml b/.ko.yaml
diff --git a/test/main.go b/test/main.go
@@ -29,9 +29,14 @@ var (
 	wait = flag.Bool("wait", true, "Whether to wait for SIGTERM")
 )
 
+// This is defined so we can test build-time variable setting using ldflags.
+var version = "default"
+
 func main() {
 	flag.Parse()
 
+	log.Println("version =", version)
+
 	dp := os.Getenv("KO_DATA_PATH")
 	file := filepath.Join(dp, *f)
 	bytes, err := ioutil.ReadFile(file)