Skip to content

add probe path for whitelisting #6505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 18 commits into from
Jan 23, 2020
Merged

add probe path for whitelisting #6505

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
210e735
add probe path for whitelisting
itsmurugappan Jan 12, 2020
dc01d9a
add e2e for probe whitelisting
itsmurugappan Jan 12, 2020
71236b5
add e2e for probe whitelisting
itsmurugappan Jan 12, 2020
24d4e54
add e2e for probe whitelisting
itsmurugappan Jan 12, 2020
974a09f
add e2e for probe whitelisting
itsmurugappan Jan 12, 2020
6ffd879
add e2e for probe whitelisting
itsmurugappan Jan 13, 2020
bd9ad84
add e2e for probe whitelisting
itsmurugappan Jan 13, 2020
ff40cb5
add e2e for probe whitelisting
itsmurugappan Jan 13, 2020
170b37f
add e2e for probe whitelisting
itsmurugappan Jan 13, 2020
7fbb6fe
add e2e for probe whitelisting
itsmurugappan Jan 13, 2020
def9ba5
add e2e for probe path whitelisting
itsmurugappan Jan 13, 2020
36e59ba
add e2e for probe path whitelisting
itsmurugappan Jan 13, 2020
c847700
e2e for whitelist probe path
itsmurugappan Jan 14, 2020
d7c9b3b
e2e for whitelist probe path
itsmurugappan Jan 14, 2020
bb80418
e2e for probe whitelist test
itsmurugappan Jan 15, 2020
2ea9a2b
e2e test for probe whitelisting
itsmurugappan Jan 16, 2020
1864bb1
e2e test for probe whitelisting
itsmurugappan Jan 16, 2020
fe01449
e2e test for probe whitelisting
itsmurugappan Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/activator/net/revision_backends.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ type revisionDestsUpdate struct {
const (
probeTimeout time.Duration = 300 * time.Millisecond
probeFrequency time.Duration = 200 * time.Millisecond
probePath = "/_internal/knative/activator/probe"

@vagababov vagababov Jan 12, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this path?

@itsmurugappan itsmurugappan Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some random path for activator to probe. It can be changed as @tcnghia has mentioned here

@vagababov vagababov Jan 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be constant here, which is fine.
It needs to be documented as well.

@vagababov vagababov Jan 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it seems quite long for a random probe path.

@tcnghia tcnghia Jan 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can follow up to extract this to a configurable option in the future.

@vagababov vagababov Jan 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please fine an issue, so it's not forgotten

)

// revisionWatcher watches the podIPs and ClusterIP of the service for a revision. It implements the logic
Expand Down Expand Up @@ -135,6 +136,7 @@ func (rw *revisionWatcher) probe(ctx context.Context, dest string) (bool, error)
httpDest := url.URL{
Scheme: "http",
Host: dest,
Path: probePath,
}
// NOTE: changes below may require changes to testing/roundtripper.go to make unit tests passing.
return prober.Do(ctx, rw.transport, httpDest.String(),
Expand Down