add probe path for whitelisting by itsmurugappan · Pull Request #6505 · knative/serving

itsmurugappan · 2020-01-12T04:13:35Z

Fixes #5918

Proposed Changes

Add a probe path thats easy to whitelist
e2e test

knative-prow-robot

@itsmurugappan: 0 warnings.

Details

In response to this:

Fixes #5918

Proposed Changes

Add a probe path thats easy to whitelist

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2020-01-12T04:13:50Z

Hi @itsmurugappan. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nak3 · 2020-01-12T05:30:18Z

/ok-to-test
/test pull-knative-serving-istio-1.4-mesh
/test pull-knative-serving-istio-1.3-mesh

test/e2e/probe_whitelist_test.go

knative-metrics-robot · 2020-01-15T01:34:35Z

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/activator/net/revision_backends.go	93.6%	93.0%	-0.6

tcnghia · 2020-01-16T17:01:48Z

/test all

itsmurugappan · 2020-01-16T18:05:59Z

/test pull-knative-serving-https

itsmurugappan · 2020-01-16T18:06:19Z

/test pull-knative-serving-istio-1.3-mesh

itsmurugappan · 2020-01-16T18:32:00Z

/test pull-knative-serving-unit-tests

test/e2e/probe_whitelist_test.go

tcnghia · 2020-01-16T19:02:01Z

/test pull-knative-serving-kourier-stable
/test pull-knative-serving-istio-1.4-mesh

knative-prow-robot · 2020-01-16T19:28:24Z

@itsmurugappan: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-serving-istio-1.4-no-mesh	`bb80418`	link	`/test pull-knative-serving-istio-1.4-no-mesh`
pull-knative-serving-gloo-0.17.1	`bb80418`	link	`/test pull-knative-serving-gloo-0.17.1`
pull-knative-serving-contour-latest	`bb80418`	link	`/test pull-knative-serving-contour-latest`
pull-knative-serving-https	`1864bb1`	link	`/test pull-knative-serving-https`
pull-knative-serving-kourier-stable	`1864bb1`	link	`/test pull-knative-serving-kourier-stable`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

knative-test-reporter-robot · 2020-01-16T19:28:29Z

The following jobs failed:

Test name	Triggers	Retries
pull-knative-serving-unit-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/reconciler/nscert.Failure

itsmurugappan · 2020-01-16T19:37:03Z

/test pull-knative-serving-unit-tests

tcnghia · 2020-01-16T20:53:12Z

@itsmurugappan it looks like we are pretty close to the release cut date (Jan 20), so I am nervous about landing this now. We are usually in code freeze around this time.

So I am going
/hold
until next week. This will shift things out one release. Apologies for the inconvenience.

itsmurugappan · 2020-01-16T20:59:51Z

@itsmurugappan it looks like we are pretty close to the release cut date (Jan 20), so I am nervous about landing this now. We are usually in code freeze around this time.

So I am going
/hold
until next week. This will shift things out one release. Apologies for the inconvenience.

Sure. No problem.

tcnghia · 2020-01-21T19:05:44Z

/hold cancel

tcnghia · 2020-01-23T21:16:41Z

@itsmurugappan let's check this in as is but let's not close the issue. I will follow up with making the probe path consistent with KPA probes as well to close the issue.

/lgtm
/approve

knative-prow-robot · 2020-01-23T21:16:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsmurugappan, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/activator/OWNERS~~ [tcnghia]
~~test/OWNERS~~ [tcnghia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

itsmurugappan · 2020-01-23T22:08:47Z

@itsmurugappan let's check this in as is but let's not close the issue. I will follow up with making the probe path consistent with KPA probes as well to close the issue.

/lgtm
/approve

@tcnghia issue got closed before I could change the issue reference in the PR. Shall I open a new one ?

add probe path for whitelisting

210e735

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 12, 2020

knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2020

knative-prow-robot reviewed Jan 12, 2020

View reviewed changes

knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/autoscale area/networking labels Jan 12, 2020

knative-prow-robot requested review from nak3 and taragu January 12, 2020 04:14

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2020

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2020

nak3 reviewed Jan 12, 2020

View reviewed changes

test/e2e/probe_whitelist_test.go Outdated Show resolved Hide resolved

knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2020

add e2e for probe whitelisting

dc01d9a

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2020

mattmoor reviewed Jan 12, 2020

View reviewed changes

add e2e for probe whitelisting

71236b5

mattmoor reviewed Jan 12, 2020

View reviewed changes

add e2e for probe whitelisting

24d4e54

mattmoor reviewed Jan 12, 2020

View reviewed changes

add e2e for probe whitelisting

974a09f

mattmoor reviewed Jan 12, 2020

View reviewed changes

e2e test for probe whitelisting

2ea9a2b

mattmoor reviewed Jan 16, 2020

View reviewed changes

e2e test for probe whitelisting

1864bb1

vagababov reviewed Jan 16, 2020

View reviewed changes

test/e2e/probe_whitelist_test.go Outdated Show resolved Hide resolved

test/e2e/probe_whitelist_test.go Outdated Show resolved Hide resolved

test/e2e/probe_whitelist_test.go Outdated Show resolved Hide resolved

e2e test for probe whitelisting

fe01449

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020

knative-prow-robot assigned tcnghia Jan 23, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020

knative-prow-robot merged commit 0ce2a6f into knative:master Jan 23, 2020

itsmurugappan mentioned this pull request Jan 23, 2020

Use better probe path than "/" for activator and KPA #5918

Closed

shreejad mentioned this pull request Mar 31, 2020

Add common probe path in autoscaler, networking and activator #7445

Merged

This was referenced Feb 27, 2026

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#6

Closed

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#11

Merged

Conversation

itsmurugappan commented Jan 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

knative-prow-robot left a comment

Choose a reason for hiding this comment

Proposed Changes

Uh oh!

knative-prow-robot commented Jan 12, 2020

Uh oh!

nak3 commented Jan 12, 2020

Uh oh!

Uh oh!

knative-metrics-robot commented Jan 15, 2020

Uh oh!

tcnghia commented Jan 16, 2020

Uh oh!

itsmurugappan commented Jan 16, 2020

Uh oh!

itsmurugappan commented Jan 16, 2020

Uh oh!

itsmurugappan commented Jan 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tcnghia commented Jan 16, 2020

Uh oh!

knative-prow-robot commented Jan 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

knative-test-reporter-robot commented Jan 16, 2020

Uh oh!

itsmurugappan commented Jan 16, 2020

Uh oh!

tcnghia commented Jan 16, 2020

Uh oh!

itsmurugappan commented Jan 16, 2020

Uh oh!

tcnghia commented Jan 21, 2020

Uh oh!

tcnghia commented Jan 23, 2020

Uh oh!

knative-prow-robot commented Jan 23, 2020

Uh oh!

itsmurugappan commented Jan 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

itsmurugappan commented Jan 12, 2020 •

edited

Loading

knative-prow-robot commented Jan 16, 2020 •

edited

Loading