Make test README compatible with a Dockerhub based setup. #2716
Conversation
knative-prow-robot
added
the
size/S
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
In response to this:
Fixes #2715
Proposed Changes
- Push test-images using just their basepath (that is: The folder they're located in, for example
timeout). That makes the upload script compatible with Dockerhub.- Actually default
--dockerrepotoDOCKER_REPO_OVERRIDEas the readmes say.Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/assign @jessiezcc |
|
/test pull-knative-serving-unit-tests |
markusthoemmes
changed the title
knative-prow-robot
added
the
do-not-merge/work-in-progress
|
@adrcunha can we update |
test/cluster.sh
Outdated
| @@ -147,9 +147,9 @@ function uninstall_knative_serving() { | |||
| # Publish all e2e test images in ${REPO_ROOT_DIR}/test/test_images/ | |||
| function publish_test_images() { | |||
| echo ">> Publishing test images" | |||
| kubectl create namespace serving-tests | |||
There was a problem hiding this comment.
This shouldn't be removed from here, see below.
test/e2e-tests.sh
Outdated
| header "Running tests" | ||
| kubectl create namespace serving-tests |
There was a problem hiding this comment.
Moving this here will break the other tests (performance, upgrade/downgrade, etc). All E2E tests expect the images to be pushed to the serving-tests namespace.
Done. |
|
/retest |
|
/hold Looks like we can't update the image used by the Prow jobs. You get |
knative-prow-robot
added
the
do-not-merge/hold
|
#2479 is resolved, merge conflict fixed, unholding. /retest |
|
Upgrade tests failed due to the missing test namespace, as expected. |
markusthoemmes
force-pushed
the
test-dockerhub
branch
from
83828d9
to
d7ae0f8
Compare
|
/test pull-knative-serving-upgrade-tests |
markusthoemmes
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
@adrcunha added the "create namespace" call back in, thanks for bumping! Should be good to go now. |
Co-Authored-By: markusthoemmes <[email protected]>
knative-prow-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Fixes #2715
Proposed Changes
timeout). That makes the upload script compatible with Dockerhub.--dockerrepotoDOCKER_REPO_OVERRIDEas the readmes say.Release Note