Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update upload-test-images.sh to compatible with docker hub #725

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

zxDiscovery
Copy link

Follow knative/serving#2715

Proposed Changes

  • Push test-images using just their basepath (that is: The folder they're located in, for example timeout). That makes the upload script compatible with Dockerhub.
  • Actually default --dockerrepo to DOCKER_REPO_OVERRIDE as the readmes say.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 15, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 15, 2019
@evankanderson
Copy link
Member

evankanderson commented Jan 15, 2019 via email

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 15, 2019
@zxDiscovery
Copy link
Author

/test pull-knative-eventing-integration-tests

1 similar comment
@zxDiscovery
Copy link
Author

/test pull-knative-eventing-integration-tests

@zxDiscovery
Copy link
Author

The CI test passed. Is this ready to merge? @evankanderson

@evankanderson
Copy link
Member

This looks to line up with knative/serving#2716

/approve
/lgtm

Sorry for the delay, I'd just put the /ok-to-test in to get the tests started on this PR.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, zxDiscovery

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2019
@knative-prow-robot knative-prow-robot merged commit 18fc070 into knative:master Jan 22, 2019
@zxDiscovery zxDiscovery deleted the test-script branch January 23, 2019 06:57
grantr added a commit to grantr/eventing that referenced this pull request Feb 11, 2019
PR knative#725 removed paths from test image names, but the e2e tests were
still generating image URLs using the previous longer paths.
knative-prow-robot pushed a commit that referenced this pull request Feb 11, 2019
PR #725 removed paths from test image names, but the e2e tests were
still generating image URLs using the previous longer paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants