-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update upload-test-images.sh to compatible with docker hub #725
Conversation
/ok-to-test
…On Tue, Jan 15, 2019 at 12:56 AM Knative Prow Robot < ***@***.***> wrote:
Hi @zxDiscovery <https://github.com/zxDiscovery>. Thanks for your PR.
I'm waiting for a knative <https://github.com/orgs/knative/people> member
to verify that this patch is reasonable to test. If it is, they should
reply with /ok-to-test on its own line. Until that is done, I will not
automatically test new commits in this PR, but the usual testing commands
by org members will still work. Regular contributors should join the org
<https://github.com/orgs/knative/people> to skip this step.
I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#725 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHlyN7bnJB46mL7aYGJqgSUPVNa1J4R5ks5vDZe6gaJpZM4aAgTb>
.
--
Evan Anderson <[email protected]>
|
/test pull-knative-eventing-integration-tests |
1 similar comment
/test pull-knative-eventing-integration-tests |
bdb37c7
to
7c684f7
Compare
7c684f7
to
febd9a2
Compare
The CI test passed. Is this ready to merge? @evankanderson |
This looks to line up with knative/serving#2716 /approve Sorry for the delay, I'd just put the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, zxDiscovery The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR knative#725 removed paths from test image names, but the e2e tests were still generating image URLs using the previous longer paths.
PR #725 removed paths from test image names, but the e2e tests were still generating image URLs using the previous longer paths.
Follow knative/serving#2715
Proposed Changes