Skip to content

[RELEASE 0.1] Update test infrastructure for the 0.1 serving release#2208

Merged
knative-prow-robot merged 4 commits intorelease-0.1from
adrcunha-patch-1
Oct 11, 2018
Merged

[RELEASE 0.1] Update test infrastructure for the 0.1 serving release#2208
knative-prow-robot merged 4 commits intorelease-0.1from
adrcunha-patch-1

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

@adrcunha adrcunha commented Oct 10, 2018 •
edited
Loading

Ensure that all tests are running against the current live Prow infrastructure.

Part of knative/test-infra#180.

@adrcunha
Fix SSH keys workaround for kubetest
1a785ea 
Create the ~/.ssh dir if it doesn't exist, don't assume it always exist.

Backported from knative/test-infra#151
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Oct 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2018
@adrcunha adrcunha requested review from imjasonh and mattmoor and removed request for steuhs October 10, 2018 19:32
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 10, 2018

/hold

There's more to fix than just SSH keys...

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2018
@adrcunha adrcunha changed the title Fix SSH keys workaround for kubetest Update test infrastructure for the 0.1 serving release Oct 10, 2018
@adrcunha
Fix authentication for test clusters
d49b51e 
Instead of relying on default options, use basic authentication for test cluster.

Also make acquire_cluster_admin_role() handle auth through certificates, since it's used also on deployment.

Backport of knative/test-infra#115
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 10, 2018

/retest

@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 10, 2018

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2018
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 10, 2018

Now I just need to issue enough /retest so the integration tests pass. :) :) :)

@adrcunha adrcunha mentioned this pull request Oct 10, 2018
Closed
@srinivashegde86
Copy link
Copy Markdown
Contributor

srinivashegde86 commented Oct 10, 2018

/test pull-knative-serving-integration-tests

1 similar comment
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 10, 2018

/test pull-knative-serving-integration-tests

@adrcunha
Increase E2E tests timeout to 20 minutes
ba291f4 
Currently 10 minutes may not be enough, for example as in #1701.

Backport of #1702.
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 11, 2018

/retest

@adrcunha adrcunha mentioned this pull request Oct 11, 2018
Closed
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 11, 2018

/retest

@bbrowning
Copy link
Copy Markdown
Contributor

bbrowning commented Oct 11, 2018

You need to explicitly publish the test images now - something similar to https://github.com/knative/serving/pull/2166/files#diff-0bff8fdbdcedf4cfbdcab24558df0df2R98 and https://github.com/knative/serving/pull/2166/files#diff-0bff8fdbdcedf4cfbdcab24558df0df2R112

@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 11, 2018

Ouch, I missed that (was just looking at the error message, without the context), thanks.

@adrcunha
Drop Dockerfile in test images
9eefc77 
* removed dockerfiles
* moved test images to the same location
* adjust repo
* fix command and docs
* update upload-test-images.sh
* preserve import paths
* fix appYaml path
* preserve path in upload-test-images.sh

Backport of #1792.
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2018
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Oct 11, 2018

All tests passed, this is ready for review.

@mattmoor mattmoor changed the title Update test infrastructure for the 0.1 serving release [RELEASE 0.1] Update test infrastructure for the 0.1 serving release Oct 11, 2018
@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Oct 11, 2018

/assign @bbrowning

@bbrowning
Copy link
Copy Markdown
Contributor

bbrowning commented Oct 11, 2018

From an ongoing maintenance standpoint, we'll need to remember that any changes in the Prow setup that require updates in the test-infra repo may require corresponding updates directly in the release-0.1 branch of the serving repo. This does not vendor a newer test-infra like #2166, but as we saw from that PR the changes required to vendor a current test-infra are much more. I think that's a worthy trade-off and overall feel much better about the amount changes in this PR than the other.

I am a little surprised the integration tests passed without the fix to prevent Istio's statsd pod from crashlooping. But perhaps since we're not vendoring a newer test-infra the check to determine if all istio pods are up may be a bit more lenient.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2018
@knative-prow-robot knative-prow-robot merged commit 89a3cf7 into release-0.1 Oct 11, 2018
@adrcunha adrcunha deleted the adrcunha-patch-1 branch October 12, 2018 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessiezcc jessiezcc Awaiting requested review from jessiezcc

@imjasonh imjasonh Awaiting requested review from imjasonh

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@bbrowning bbrowning

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrcunha @knative-prow-robot @srinivashegde86 @bbrowning @mattmoor