Increase E2E tests timeout to 20 minutes.#1702
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jul 25, 2018
adrcunha:more-time
Merged
Increase E2E tests timeout to 20 minutes.#1702google-prow-robot merged 1 commit intoknative:masterfrom adrcunha:more-time
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:more-time
Conversation
Currently 10 minutes may not be enough, for example as in #1701.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
google-prow-robot
added
the
size/XS
Contributor
|
/lgtm |
Contributor
|
/lgtm |
ZhiminXiang
pushed a commit
to ZhiminXiang/serving-1
that referenced
this pull request
Aug 2, 2018
Currently 10 minutes may not be enough, for example as in knative#1701.
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 11, 2018
…2208) * Fix SSH keys workaround for kubetest Create the ~/.ssh dir if it doesn't exist, don't assume it always exist. Backported from knative/test-infra#151 * Fix authentication for test clusters Instead of relying on default options, use basic authentication for test cluster. Also make acquire_cluster_admin_role() handle auth through certificates, since it's used also on deployment. Backport of knative/test-infra#115 * Increase E2E tests timeout to 20 minutes Currently 10 minutes may not be enough, for example as in #1701. Backport of #1702. * Drop Dockerfile in test images * removed dockerfiles * moved test images to the same location * adjust repo * fix command and docs * update upload-test-images.sh * preserve import paths * fix appYaml path * preserve path in upload-test-images.sh Backport of #1792.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently 10 minutes may not be enough, for example as in #1701.
With future work like knative/test-infra#20 we hopefully will be able to bring this down.