Skip to content

[RELEASE 0.1] Update to build v0.1.2 release#2050

Merged
knative-prow-robot merged 1 commit intoknative:release-0.1from
imjasonh:release-0.1
Oct 17, 2018
Merged

[RELEASE 0.1] Update to build v0.1.2 release#2050
knative-prow-robot merged 1 commit intoknative:release-0.1from
imjasonh:release-0.1

Conversation

@imjasonh
Copy link
Copy Markdown
Contributor

Release Note

Update to build v0.1.2 release

/assign mattmoor

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2018
@mattmoor
Copy link
Copy Markdown
Member

/test pull-knative-serving-integration-tests

@mattmoor
Copy link
Copy Markdown
Member

/lgtm
/approve

/assign @evankanderson

Adding Evan for a second set of eyeballs, we'll need to manually merge this anyways.

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2018
@mattmoor
Copy link
Copy Markdown
Member

/test pull-knative-serving-integration-tests

@mattmoor mattmoor changed the title Update to build v0.1.2 release [RELEASE 0.1] Update to build v0.1.2 release Sep 19, 2018
@evankanderson
Copy link
Copy Markdown
Member

/approve

In the future, we should include the order of magnitude of the build speed up in the justification for cutting an 0.0.1 release. (Or other similar cut.) Some properties of a new release:

  • Everyone has to evaluate whether to upgrade. This will be more important as our installed base grows.
  • Someone has to run the actual release machinery, and hopefully we aren't creating too many point releases, so people will be rusty, or it will always be one person.
  • We probably need to handle all the upgrade combinations, which means more combos to test against head.

Given our current state with 0.1 and the build speed tradeoffs, this seems like it may cross the bar.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, ImJasonH, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Copy Markdown
Member

/test pull-knative-serving-integration-tests

1 similar comment
@dprotaso
Copy link
Copy Markdown
Member

/test pull-knative-serving-integration-tests

@bbrowning
Copy link
Copy Markdown
Contributor

At least 2 of those integration failures were flakes, which should be reduced in frequency now.

/test pull-knative-serving-integration-tests

@bbrowning
Copy link
Copy Markdown
Contributor

And then a test infra fail - let's try this again. If it fails again I'll go poke the test scripts and see what's up.

/test pull-knative-serving-integration-tests

@bbrowning
Copy link
Copy Markdown
Contributor

So...there are some test-infra changes that need to be applied to the release-0.1 branch if we want to get these integration tests passing. Do we expect to cut another 0.1.x release? Or will the next one be 0.2?

I've taken a brief look at the changes required and didn't want to invest the time into getting tests going again on release-0.1 branch unless we plan to actually cut a release from there.

@jessiezcc
Copy link
Copy Markdown
Contributor

jessiezcc commented Oct 5, 2018

this is the same issue at seen with #1922, @srinivashegde86 has root caused it. A few options: backport test-infra ssh change to release branch, or revert it, or do manual merge

@bbrowning
Copy link
Copy Markdown
Contributor

Ok - I'll work on backporting the various test-infra changes between this branch and master.

@bbrowning
Copy link
Copy Markdown
Contributor

The release-0.1 tests hould be unblocked now.

/retest

@knative-prow-robot knative-prow-robot merged commit 698d756 into knative:release-0.1 Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants