use prometheus statsd_exporter v0.6.0 by simingweng · Pull Request #1922 · knative/serving

simingweng · 2018-08-22T15:53:07Z

Fixes #1921

Proposed Changes

set the statsd_exporter Docker image to v0.6.0, so it still supports single dash command line argument

sdake

/lgtm

See #1921 (comment) for my analysis. Also, I tested this change against the release-0.1 branch. I was wondering why the documentation was causing statsd to break. A problem in Istio 0.8. That said, I'm not sure when/if Istio will release a 0.8 z stream.

cc @hklai

knative-prow-robot · 2018-08-26T14:40:24Z

@sdake: changing LGTM is restricted to assignees, and only knative/serving repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

See #1921 (comment) for my analysis. Also, I tested this change against the release-0.1 branch. I was wondering why the documentation was causing statsd to break. A problem in Istio 0.8. That said, I'm not sure when/if Istio will release a 0.8 z stream.

cc @hklai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdake · 2018-08-26T14:41:02Z

/assign @mdemirhan

sdake · 2018-08-26T16:03:06Z

See istio/istio#8249 for upstream Istio resolution.

tcnghia · 2018-09-02T17:31:49Z

/lgtm
/approve
/ok-to-test

tcnghia · 2018-09-12T16:21:59Z

/test pull-knative-serving-integration-tests

tcnghia · 2018-09-26T15:31:46Z

/test pull-knative-serving-integration-tests

tcnghia · 2018-09-26T15:41:02Z

/assign @mattmoor
/assign @mdemirhan
for approval

tcnghia · 2018-09-26T17:15:19Z

/test pull-knative-serving-integration-tests

tcnghia · 2018-09-26T17:33:30Z

This should fix #1921

tcnghia · 2018-09-26T17:54:49Z

/retest

tcnghia · 2018-09-26T18:32:42Z

Seems integration tests no longer passing on our release branch. I'll try running on my cluster.

mdemirhan · 2018-09-27T15:55:12Z

/lgtm
/approve

tcnghia · 2018-09-27T16:56:48Z

/test pull-knative-serving-integration-tests

tcnghia · 2018-09-28T14:24:24Z

/test pull-knative-serving-integration-tests

mdemirhan · 2018-10-01T20:37:35Z

/test pull-knative-serving-integration-tests

mdemirhan · 2018-10-01T20:40:41Z

@adrcunha Can you please take a look and let us know how we can get past the integration tests?

mdemirhan · 2018-10-04T21:10:07Z

/test pull-knative-serving-integration-tests

mdemirhan · 2018-10-04T21:22:31Z

@adrcunha @jessiezcc This PR is blocked due to infra issues. This is something we should checkin as it is breaking some users. Can this please be prioritized?

jessiezcc · 2018-10-04T21:31:23Z

@srinivashegde86 to help take a look. Test seems to fail with "main.go:309: Something went wrong: failed to prepare test environment: stat /root/.ssh/google_compute_engine: no such file or directory"

srinivashegde86 · 2018-10-04T23:27:37Z

this was the ssh issue, which was fixed 2 days ago by http://go/gh/knative/serving/pull/2125

Maybe its not picking the latest test-infra scripts

srinivashegde86 · 2018-10-04T23:28:29Z

/test pull-knative-serving-integration-tests

jessiezcc · 2018-10-04T23:35:50Z

the test seems only fail for this PR, not others

srinivashegde86 · 2018-10-04T23:36:15Z

can we rebase and try again? For some reason, we seem to be using the older version of the test-infra scripts under vendor/ for this PR.

The other PR's have passing runs.

tcnghia · 2018-10-05T01:40:41Z

This PR is on the release-0.1 branch, not the master branch.

srinivashegde86 · 2018-10-05T03:23:36Z

we removed the ssh requirement recently, but it has not been ported back to the release branch and only to master. That looks like a breaking change atleast for running prow.

tcnghia · 2018-10-05T15:51:24Z

May be we should run test manually and merge manually for release branch?

bbrowning · 2018-10-05T20:31:12Z

I'm working on unblocking the release branch in issue #2165 and PR #2166.

simplytunde · 2018-10-11T02:08:36Z

I will like this to get good tracking for the fix to be pushed out for GKE setup

mdemirhan · 2018-10-11T20:25:57Z

/test pull-knative-serving-integration-tests

mdemirhan · 2018-10-12T00:07:12Z

/lgtm
/approve

knative-prow-robot · 2018-10-12T00:07:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdemirhan, simingweng, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~third_party/OWNERS~~ [mdemirhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

use prometheus statsd_exporter v0.6.0

2d0d251

knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2018

knative-prow-robot requested review from mdemirhan and vaikas August 22, 2018 15:53

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2018

sdake approved these changes Aug 26, 2018

View reviewed changes

knative-prow-robot assigned mdemirhan Aug 26, 2018

knative-prow-robot assigned tcnghia Sep 2, 2018

knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2018

knative-prow-robot assigned mattmoor Sep 26, 2018

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2018

mdemirhan mentioned this pull request Oct 1, 2018

istio-statsd-prom-bridge is in crashloopbackoff in Knative v0.1.1 deployment #1921

Closed

This was referenced Oct 5, 2018

[RELEASE 0.1] Update to build v0.1.2 release #2050

Merged

Investigate how to prevent test-infra outage for release branches knative/test-infra#177

Closed

bbrowning mentioned this pull request Oct 5, 2018

Fix release 0.1 tests #2166

Closed

Merge branch 'release-0.1' into fix-statsd-exporter-docker-image-version

8f1882d

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2018

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018

knative-prow-robot merged commit 88a115b into knative:release-0.1 Oct 12, 2018

jonjohnsonjr mentioned this pull request Oct 17, 2018

Upgrade testing #2223

Closed

Conversation

simingweng commented Aug 22, 2018

Proposed Changes

Uh oh!

sdake left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Aug 26, 2018

Uh oh!

sdake commented Aug 26, 2018

Uh oh!

sdake commented Aug 26, 2018

Uh oh!

tcnghia commented Sep 2, 2018

Uh oh!

tcnghia commented Sep 12, 2018

Uh oh!

tcnghia commented Sep 26, 2018

Uh oh!

tcnghia commented Sep 26, 2018

Uh oh!

tcnghia commented Sep 26, 2018

Uh oh!

tcnghia commented Sep 26, 2018

Uh oh!

tcnghia commented Sep 26, 2018

Uh oh!

tcnghia commented Sep 26, 2018

Uh oh!

mdemirhan commented Sep 27, 2018

Uh oh!

tcnghia commented Sep 27, 2018

Uh oh!

tcnghia commented Sep 28, 2018

Uh oh!

mdemirhan commented Oct 1, 2018

Uh oh!

mdemirhan commented Oct 1, 2018

Uh oh!

mdemirhan commented Oct 4, 2018

Uh oh!

mdemirhan commented Oct 4, 2018

Uh oh!

jessiezcc commented Oct 4, 2018

Uh oh!

srinivashegde86 commented Oct 4, 2018

Uh oh!

srinivashegde86 commented Oct 4, 2018

Uh oh!

jessiezcc commented Oct 4, 2018

Uh oh!

srinivashegde86 commented Oct 4, 2018

Uh oh!

tcnghia commented Oct 5, 2018

Uh oh!

srinivashegde86 commented Oct 5, 2018

Uh oh!

tcnghia commented Oct 5, 2018

Uh oh!

bbrowning commented Oct 5, 2018

Uh oh!

simplytunde commented Oct 11, 2018

Uh oh!

mdemirhan commented Oct 11, 2018

Uh oh!

mdemirhan commented Oct 12, 2018

Uh oh!

knative-prow-robot commented Oct 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants