Update the vendored test-infra scripts to the latest version#1916
Merged
knative-prow-robot merged 2 commits intoknative:masterfrom Aug 24, 2018
adrcunha:update-ti-again
Merged
Update the vendored test-infra scripts to the latest version#1916knative-prow-robot merged 2 commits intoknative:masterfrom adrcunha:update-ti-again
knative-prow-robot merged 2 commits intoknative:masterfrom
adrcunha:update-ti-again
Conversation
knative-prow-robot
added
the
size/M
knative-prow-robot
added
size/L
Contributor
Author
|
/hold for knative/test-infra#87 |
knative-prow-robot
added
the
do-not-merge/hold
Also use `check_licenses()` from `library.sh`, this will transparently handle the installation of `dep-collector` (if necessary).
Contributor
Author
|
/hold cancel This is now ready for review. |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Member
|
/lgtm |
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
Rebased the PR, hopefully this will get rid of the excessive flakiness in the E2E tests. |
Member
|
/lgtm |
bbrowning
pushed a commit
to bbrowning/serving
that referenced
this pull request
Oct 5, 2018
Also use `check_licenses()` from `library.sh`, this will transparently handle the installation of `dep-collector` (if necessary).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major enhancements include:
Major fixes include:
wait_until_pods_runningBonus: use
check_licenses()fromlibrary.sh, this will transparently handle the installation ofdep-collector(if necessary).