Skip to content

Use check_licenses() from library.sh#1892

Closed
adrcunha wants to merge 3 commits intoknative:masterfrom
adrcunha:fix-dep-collector
Closed

Use check_licenses() from library.sh#1892
adrcunha wants to merge 3 commits intoknative:masterfrom
adrcunha:fix-dep-collector

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

@adrcunha adrcunha commented Aug 20, 2018

This will transparently handle the installation of dep-collector (if necessary).

@adrcunha
Use check_licenses() from library.sh
1f67c63 
This will transparently handle the installation of `dep-collector` (if necessary).
@adrcunha adrcunha requested review from dprotaso and removed request for jessiezcc and vaikas August 20, 2018 18:36
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 20, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 20, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adrcunha
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattmoor

If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dprotaso
dprotaso reviewed Aug 20, 2018
View reviewed changes
Gopkg.lock
digest = "1:218ae0d3f01ab221e2a62493a88e72189fb4941b22f60984277c22f664d34c46"
name = "cloud.google.com/go"
packages = ["compute/metadata"]
pruneopts = "NUT"
Copy link
Copy Markdown
Member

@dprotaso dprotaso Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update dep to v0.5 and some of these diffs will go away

Copy link
Copy Markdown
Contributor Author

@adrcunha adrcunha Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip, done.

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2018
@adrcunha adrcunha requested a review from mattmoor August 20, 2018 20:55
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Aug 20, 2018

/retest

@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Aug 21, 2018

/hold

(I might upgrade this PR to also include knative/test-infra#86)

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2018
@adrcunha adrcunha closed this Aug 21, 2018
@adrcunha adrcunha deleted the fix-dep-collector branch August 21, 2018 22:18
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Aug 21, 2018

For the record, #1916 already includes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso dprotaso left review comments

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrcunha @knative-prow-robot @dprotaso