Activator: Shouldn't use http.DefaultTransport

[dprotaso]

serving/cmd/activator/main.go

Line 48 in 34a7680

transport := http.DefaultTransport

By default it doesn't have any default timeouts

See:

• net/http: make default configs have better timeouts golang/go#24138
• https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/

[mattmoor]

/kind good-first-issue

[erain]

/assign erain

[erain]

I believe we don't need to fix this issue anymore, since DefaultTransport in latest golang release already has default timeouts?

https://github.com/golang/go/blob/dbd323bb880ff27fa9b4bdfebf3e5d4828b09678/src/net/http/transport.go#L42-L53

[erain]

@mattmoor could we close this issue?

[tcnghia]

@dprotaso do you still see a need for a different transport?

[k4leung4]

@dprotaso any comment on this or should we close?

[dprotaso]

Hey sorry for the delay.

This issue is still present since the DefaultTransport doesn't set a ResponseHeaderTimeout

Thus if the server doesn't shutdown gracefully and the activator doesn't receive HTTP headers it hangs.

[hohaichi]

@jonjohnsonjr this issue seems to be fixed by your PR#3409, right?

[jonjohnsonjr]

Not for the activator. That PR only fixed the transport for tag -> digest resolution.

[vagababov]

I think Nghia did some change to have our own transport.

…

On Mon, Apr 22, 2019 at 11:21 AM jonjohnsonjr ***@***.***> wrote: Not for the activator. That PR only fixed the transport for tag -> digest resolution. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1238 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAF2WX6L6S6YB3B6T5BPF63PRX64NANCNFSM4FFIUFTQ> .

[mattmoor]

Fixed by: #3794

[dprotaso]

Isn’t the default ResponseHeaderTimeout <https://github.com/golang/go/blob/release-branch.go1.12/src/net/http/transport.go#L218-L222> still an issue?

…

On Fri, Apr 26, 2019 at 16:46 Matt Moore ***@***.***> wrote: Closed #1238 <#1238>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1238 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAERAVRAU2XTE64JE4XUILPSNSZFANCNFSM4FFIUFTQ> .

[tcnghia]

/cc @vagababov