Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct a better resolver transport #3409

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Construct a better resolver transport #3409

merged 3 commits into from
Mar 19, 2019

Conversation

jonjohnsonjr
Copy link
Contributor

@jonjohnsonjr jonjohnsonjr commented Mar 11, 2019 •
edited
Loading

This replicates the settings from http.DefaultTransport. Notably, we
were missing ProxyFromEnvironment, causing HTTPS_PROXY env variables not
to work.

Fixes #3392

Release Note

@jonjohnsonjr
Construct a better resolver transport
07b852b 
This replicates the settings from http.DefaultTransport. Notably, we
were missing ProxyFromEnvironment, causing HTTPS_PROXY env variables not
to work.
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2019
knative-prow-robot
knative-prow-robot reviewed Mar 11, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonjohnsonjr: 0 warnings.

In response to this:

This replicates the settings from http.DefaultTransport. Notably, we
were missing ProxyFromEnvironment, causing HTTPS_PROXY env variables not
to work.

Fixes #3392

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jonjohnsonjr
Copy link
Contributor Author

/retest

@jonjohnsonjr jonjohnsonjr mentioned this pull request Mar 11, 2019
Closed
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/revision/resolve.go 96.0% 96.3% 0.3

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2019
@jonjohnsonjr
Copy link
Contributor Author

/retest

@markusthoemmes
Copy link
Contributor

Unrelated test failure:

I0313 22:12:15.193] panic: Log in goroutine after TestAutoscaleUpCountPods has completed
I0313 22:12:15.193] 
I0313 22:12:15.193] goroutine 6910 [running]:
I0313 22:12:15.193] testing.(*common).logDepth(0xc000188e00, 0xc00217c680, 0x1a, 0x3)
I0313 22:12:15.194] 	/usr/local/go/src/testing/testing.go:634 +0x51a
I0313 22:12:15.194] testing.(*common).log(...)
I0313 22:12:15.194] 	/usr/local/go/src/testing/testing.go:614
I0313 22:12:15.194] testing.(*common).Logf(0xc000188e00, 0x1d446c0, 0x10, 0xc002381ed0, 0x1, 0x1)
I0313 22:12:15.194] 	/usr/local/go/src/testing/testing.go:649 +0x91
I0313 22:12:15.194] github.com/knative/serving/test/e2e.generateTraffic.func1(0x8, 0x1dcedf0)
I0313 22:12:15.194] 	/go/src/github.com/knative/serving/test/e2e/autoscale_test.go:94 +0x96d
I0313 22:12:15.194] github.com/knative/serving/vendor/golang.org/x/sync/errgroup.(*Group).Go.func1(0xc001a36660, 0xc00266f280)
I0313 22:12:15.194] 	/go/src/github.com/knative/serving/vendor/golang.org/x/sync/errgroup/errgroup.go:58 +0x65
I0313 22:12:15.194] created by github.com/knative/serving/vendor/golang.org/x/sync/errgroup.(*Group).Go
I0313 22:12:15.195] 	/go/src/github.com/knative/serving/vendor/golang.org/x/sync/errgroup/errgroup.go:55 +0x74

/test pull-knative-serving-integration-tests

markusthoemmes
markusthoemmes reviewed Mar 14, 2019
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonjohnsonjr is this still a Draft?

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2019
@markusthoemmes markusthoemmes mentioned this pull request Mar 14, 2019
Merged
@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review March 14, 2019 18:38
@jonjohnsonjr
Copy link
Contributor Author

I suppose not!

@jonjohnsonjr
Copy link
Contributor Author

/assign @mattmoor @dprotaso

@jonjohnsonjr
Copy link
Contributor Author

/assign @vagababov

vagababov
vagababov approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mattmoor
Copy link
Member

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonjohnsonjr, mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2019
@knative-prow-robot knative-prow-robot merged commit 3ade774 into knative:master Mar 19, 2019
@jonjohnsonjr jonjohnsonjr deleted the proxy branch April 17, 2019 23:04
@jonjohnsonjr jonjohnsonjr mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@markusthoemmes markusthoemmes markusthoemmes left review comments

@vagababov vagababov vagababov approved these changes

@dgerd dgerd Awaiting requested review from dgerd

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@dprotaso dprotaso

@vagababov vagababov

@markusthoemmes markusthoemmes

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jonjohnsonjr @knative-metrics-robot @markusthoemmes @mattmoor @knative-prow-robot @vagababov @dprotaso