update k8s to 1.25.2

[nader-ziada]

Changes

• update k8s library to 1.25.2

Fixes #2598

Release Note

Update k8s library to 1.25.2

/cc @psschwei

[codecov]

Codecov Report

Base: 81.29% // Head: 81.29% // No change to project coverage 👍

Coverage data is based on head (0738247) compared to base (bc93b0a).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2599   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files         162      162           
  Lines        9820     9820           
=======================================
  Hits         7983     7983           
  Misses       1597     1597           
  Partials      240      240           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[nader-ziada]

/hold

[nader-ziada]

/retest

[nader-ziada]

@pierDipi @lionelvillard seems all the eventing downstream tests get broken with the update to k8s 1.25.2, I think a big part of it is updating the version of cloud-events

[lionelvillard]

retesting after knative/eventing#6552

/retest

[lionelvillard]

It's an antlr problem. k8s 1.25 picks up a newer not-backward compatible antlr. I'll submit a PR in the ce SDK repo.

[lionelvillard]

btw k8s 1.25 requires go 1.19. It does not seem to use any new go features so the build does not break but I think it's probably better to align with what k8s is doing.

[lionelvillard]

here is the PR cloudevents/sdk-go#806

[lionelvillard]

/retest

For eventing.

[nader-ziada]

/retest

For eventing.

seems like a different issue this time

[nader-ziada]

@lionelvillard

do you think we can get this fixed for the release next week?

[lionelvillard]

@nader-ziada yes. Eventing needs to be updated to 1.25.2 as well (best guess)

[nader-ziada]

/retest

[nader-ziada]

@lionelvillard @psschwei does this PR need to be merged in first then we fix the downstream issues? or how does this work?

[psschwei]

@lionelvillard @psschwei does this PR need to be merged in first then we fix the downstream issues? or how does this work?

Yeah, we should make the update here first and then the fixes downstream, assuming everyone's ready. We should be good from the serving side, @lionelvillard can confirm for eventing.

[lionelvillard]

@nader-ziada the eventing PR is ready. We'll have to propagate the changes to eventing downstream repos

[lionelvillard]

the only caveat is easycla is broken for knative/eventing

[psschwei]

EasyCLA should be fixed now, so...

[psschwei]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [psschwei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nader-ziada]

/hold cancel