Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump k8s version to 1.25.2 #6561

Merged
merged 1 commit into from
Oct 11, 2022
Merged

bump k8s version to 1.25.2 #6561

merged 1 commit into from
Oct 11, 2022

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • update k8s library to 1.25.2

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Update k8s library to 1.25.2

Docs

/hold
depends on knative/pkg#2599. When merged the replace statement needs to be removed.

/cc @nader-ziada

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 6, 2022
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 6, 2022
@lionelvillard lionelvillard force-pushed the k8s-1.25.2 branch 2 times, most recently from 632aa6f to a3e7fc3 Compare October 6, 2022 17:16
@knative-prow knative-prow bot added area/performance area/test-and-release Test infrastructure, tests or release labels Oct 6, 2022
@lionelvillard
Copy link
Member Author

/test unit-tests

known flake

@lionelvillard lionelvillard reopened this Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022 •
edited
Loading

Codecov Report

Base: 81.94% // Head: 81.89% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (945f5f5) compared to base (d1827fc).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6561      +/-   ##
==========================================
- Coverage   81.94%   81.89%   -0.05%     
==========================================
  Files         235      235              
  Lines       11737    11745       +8     
==========================================
+ Hits         9618     9619       +1     
- Misses       1646     1650       +4     
- Partials      473      476       +3
Impacted Files Coverage Δ
pkg/eventfilter/subscriptionsapi/exact_filter.go 57.14% <0.00%> (-9.53%) ⬇️
pkg/eventfilter/subscriptionsapi/prefix_filter.go 68.96% <0.00%> (-7.04%) ⬇️
pkg/eventfilter/subscriptionsapi/suffix_filter.go 68.96% <0.00%> (-7.04%) ⬇️
pkg/broker/filter/filter_handler.go 75.85% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lionelvillard
Copy link
Member Author

/easycla

2 similar comments
@lionelvillard
Copy link
Member Author

/easycla

@jarias-lfx
Copy link

/easycla

@lionelvillard lionelvillard changed the title WIP: bump k8s version to 1.25.2 bump k8s version to 1.25.2 Oct 11, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2022
@lionelvillard
Copy link
Member Author

/unhold

knative/pkg#2599 merged.

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2022
pierDipi
pierDipi approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 2899fce into knative:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@nader-ziada nader-ziada Awaiting requested review from nader-ziada

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/performance area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionelvillard @jarias-lfx @pierDipi