-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash looping when leader election config doesn't exist #1142
Fix crash looping when leader election config doesn't exist #1142
Conversation
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Whoops, can't believe I missed that. Should we un-export NewConfigFromMap?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, pmorie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Same :(
It doesn't look like it's used, and I don't see there being a reason for it to be exported, so I'm cool with that and will raise a PR |
…1143) Co-authored-by: Knative Prow Robot <[email protected]>
This fixes an issue where a controller will crashloop if a leader election config doesn't exist.