Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Update to latest pkg 0.13 #1004

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Update to latest pkg 0.13 #1004

merged 1 commit into from
Mar 10, 2020

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented Mar 7, 2020

Brings in knative/pkg#1142 and knative/pkg#1145:

  • correct behavior when leader election config doesn't exist
  • fix problem with invalid prometheus metrics names with some controllers

Release Note

- correct behavior when leader election config doesn't exist
- fix problem with invalid prometheus metrics names with some controller names

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 7, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2020
@pmorie
Copy link
Member Author

pmorie commented Mar 9, 2020

/retest

@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@knative-prow-robot knative-prow-robot merged commit a81a061 into knative:release-0.13 Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grantr grantr Awaiting requested review from grantr

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmorie @n3wscott @knative-prow-robot @googlebot