Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the v1alpha1 api versions all together #3494

Merged
merged 1 commit into from
Jul 9, 2020
Merged

remove the v1alpha1 api versions all together #3494

merged 1 commit into from
Jul 9, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 3, 2020

The presence of the fields is causing noise in the webhook logs for some reason.

Proposed Changes

  • Remove all the v1alpha1 versions from the CRD (was served=false, stored=false).

Release Note

- 🧽 Update or clean up current behavior
Remove the v1alpha1 CRD api versions.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 3, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2020
n3wscott
n3wscott approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok
Copy link
Member

aliok commented Jul 6, 2020

/retest

@aliok
Copy link
Member

aliok commented Jul 6, 2020 •
edited
Loading

/assign

@knative-prow-robot knative-prow-robot assigned aliok and unassigned n3wscott Jul 6, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-upgrade-tests:

test/upgrade.TestContinuousEventsPropagationWithProber

@vaikas
Copy link
Contributor Author

vaikas commented Jul 8, 2020

/test pull-knative-eventing-upgrade-tests

@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@knative-prow-robot knative-prow-robot merged commit 5295d3e into knative:master Jul 9, 2020
@vaikas vaikas deleted the drop-versions branch July 9, 2020 00:03
@capri-xiyue capri-xiyue mentioned this pull request Oct 26, 2020
Merged
@runzexia runzexia mentioned this pull request Apr 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott approved these changes

@Harwayne Harwayne Awaiting requested review from Harwayne

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@aliok aliok

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vaikas @knative-prow-robot @aliok @knative-test-reporter-robot @lionelvillard @n3wscott @googlebot