Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Remove v1alpha1 support for knative-gcp sources and Pub/Sub core resources #1858

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Remove v1alpha1 support for knative-gcp sources and Pub/Sub core resources #1858

merged 1 commit into from
Oct 26, 2020

Conversation

eclipselu
Copy link
Contributor

@eclipselu eclipselu commented Oct 23, 2020 •
edited
Loading

Part of #1544 , follow up to #1853 , need rebase once #1853 is merged.

Proposed Changes

  • 🗑️ Remove v1alpha1 support for knative-gcp sources
  • 🗑️ Remove v1alpha1 support for Pub/Sub core resources

Release Note

Dropped v1alpha1 support for the following resources:

- CloudPubSubSource
- CloudStorageSource
- CloudSchedulerSource
- CloudAuditLogsSource
- CloudBuildSource
- Topic
- PullSubscription

Docs

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Oct 23, 2020
@eclipselu
Remove v1alpha1 support for knative-gcp sources and Pub/Sub core reso…
7d5d089 
…urces

the following resources are affected:

- CloudPubSubSource
- CloudStorageSource
- CloudSchedulerSource
- CloudAuditLogsSource
- CloudBuildSource
- Topic
- PullSubscription
@eclipselu eclipselu changed the title [WIP] Remove v1alpha1 support for knative-gcp sources and Pub/Sub core resources Remove v1alpha1 support for knative-gcp sources and Pub/Sub core resources Oct 26, 2020
capri-xiyue
capri-xiyue reviewed Oct 26, 2020
View reviewed changes
config/core/resources/cloudauditlogssource.yaml
name: v1alpha1
# TODO: Flip served bit of v1alpha1 in https://github.com/google/knative-gcp/issues/1544.
served: true
served: false
Copy link
Contributor

@capri-xiyue capri-xiyue Oct 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked knative-eventing. It looks like knative eventing just deleted v1alpha1 version in crd definition.
Maybe create another issue to clean all v1alpha1 version in crds. It may need addition work to clean the crds if other version schema depends on v1alpha1 schema.

@capri-xiyue
Copy link
Contributor

capri-xiyue commented Oct 26, 2020 •
edited
Loading

/lgtm
/approve
@eclipselu Can you create follow up issues to get rid of v1alpha1 related stuffs in relevant CRDs instead of just setting them served to false? Examples: knative/eventing#3494

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, eclipselu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9b9bde1 into google:master Oct 26, 2020
@eclipselu eclipselu mentioned this pull request Oct 26, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@capri-xiyue capri-xiyue capri-xiyue left review comments

@ericlem ericlem Awaiting requested review from ericlem

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@capri-xiyue capri-xiyue

Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eclipselu @capri-xiyue @knative-prow-robot