-
Notifications
You must be signed in to change notification settings - Fork 225
Adding NatssChannel CRD for release script #517
Conversation
/approve |
hack/release.sh
Outdated
@@ -28,6 +28,7 @@ COMPONENTS=( | |||
["camel.yaml"]="camel/source/config" | |||
["kafka-importer.yaml"]="kafka/source/config" | |||
["kafka-channel.yaml"]="kafka/channel/config" | |||
["natss.yaml"]="natss/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called natss-channel.yaml
? I know we don't have a NATSS importer, but it might be less confusing to users if all channels have the -channel
suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/cancel hold @grantr updated! good point! |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, matzew, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
Release Note