Add Nats channel CRD implementation

[montaro]

Fixes knative/eventing#1567

Release Note

Added Nats channel CRD implementation

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[knative-prow-robot]

Hi @montaro. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[vaikas]

Thanks so much for doing this. I think I'd like to just move over the CRD based implementation. Let's leave the CCP for the eventing, then remove it right after cutting 0.8 and then this will be the correct CRD to use. Thoughts?
@Harwayne

[vaikas]

/ok-to-test

[vaikas]

@n3wscott / @Harwayne / @nachocano what should the story be here for e2e tests?

[nachocano]

@n3wscott / @Harwayne / @nachocano what should the story be here for e2e tests?

As you mentioned above, I think we should only move the CRD based channels, together with their e2e tests here. And leave the provisioner code and their e2e tests in eventing. We'll remove them next week after the 0.8 cut.
We may need help from @Fredy-Z for e2e test migration.

[montaro]

@vaikas-google Hey, I fixed all the review comments, can you please review now?

[vaikas]

/lgtm
/approve

[knative-prow-robot]

The following users are mentioned in OWNERS file(s) but are not members of the knative org.

• natss-reviewers
  • natss/OWNERS
• natss-approvers
  • natss/OWNERS

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
natss/pkg/apis/messaging/v1alpha1/natss_channel_defaults.go	Do not exist	0.0%
natss/pkg/apis/messaging/v1alpha1/natss_channel_lifecycle.go	Do not exist	100.0%
natss/pkg/apis/messaging/v1alpha1/natss_channel_types.go	Do not exist	0.0%
natss/pkg/apis/messaging/v1alpha1/natss_channel_validation.go	Do not exist	100.0%
natss/pkg/apis/messaging/v1alpha1/register.go	Do not exist	0.0%
natss/pkg/reconciler/controller/natsschannel.go	Do not exist	80.6%
natss/pkg/reconciler/controller/resources/service.go	Do not exist	100.0%
natss/pkg/stanutil/stanutil.go	Do not exist	58.6%

[knative-prow-robot]

@montaro: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-knative-eventing-contrib-go-coverage	5833fe0	link	/test pull-knative-eventing-contrib-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vaikas]

/verify-owners

[grantr]

/verify-owners

[vaikas]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: montaro, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grantr]

Prow is blocking merge here because the OWNERS_ALIASES file (in master) doesn't contain the aliases referenced in this OWNERS file. #511 fixed that (in master), but this branch doesn't have that change yet. Most likely master would need to be merged into this branch to fix the owners issue.

I think it's fine to override the label in this case.