Fix the value of the Kafka broker class to Kafka
#4090
Conversation
@matzew it's only "Kafka" without a broker suffix, right? (which is a bit confusing as the other class that I know (`MTChannelBasedBroker`) uses a different scheme (e.g. should then be `KafkaBasedBroker`). Btw would have preferred just an `MTChannel` as the broker class as the `BasedBroker` is really superfluous and redundant. (cc: @lionelvillard )
|
✔️ Deploy Preview for knative ready! 🔨 Explore the source changes: c937821 🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/6107ace4133d7d000711f542 😎 Browse the preview: https://deploy-preview-4090--knative.netlify.app |
knative-prow-robot
added
size/XS
rhuss
changed the title
KafkaKafka
The preview does not reflect the change of this PR. Could it be, that the preview is always build from the main branch ? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@matzew it's only "Kafka" without a broker suffix, right? (which is a bit confusing as the other class that I know (
MTChannelBasedBroker) uses a different scheme (e.g. should then beKafkaBasedBroker). Btw would have preferred just anMTChannelas the broker class as theBasedBrokeris really superfluous and redundant. (cc: @lionelvillard )