Skip to content

Commit

Permalink
Fixe the value of the Kafka broker class to Kafka (#4090)
Browse files Browse the repository at this point in the history
@matzew it's only "Kafka" without a broker suffix, right? (which is a bit confusing as the other class that I know (`MTChannelBasedBroker`) uses a different scheme (e.g. should then be `KafkaBasedBroker`). Btw would have preferred just an `MTChannel` as the broker class as the `BasedBroker` is really superfluous and redundant. (cc: @lionelvillard )
  • Loading branch information
rhuss authored Aug 9, 2021
1 parent 17cdee4 commit 1b74ec3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/eventing/broker/example-mtbroker.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ metadata:
- You can specify any valid `name` for your broker. Using `default` will create a broker named `default`.
- The `namespace` must be an existing namespace in your cluster. Using `default` will create the broker in the current namespace.
- You can set the `eventing.knative.dev/broker.class` annotation to change the class of the broker. The default broker class is `MTChannelBasedBroker`, but Knative also supports use of the `KafkaBroker` class. For more information about Kafka brokers, see the [Apache Kafka Broker](../kafka-broker) documentation.
- You can set the `eventing.knative.dev/broker.class` annotation to change the class of the broker. The default broker class is `MTChannelBasedBroker`, but Knative also supports use of the `Kafka` broker class. For more information about Kafka brokers, see the [Apache Kafka Broker](../kafka-broker) documentation.
- `spec.config` is used to specify the default backing channel configuration for MT channel-based broker implementations. For more information on configuring the default channel type, see the documentation on [ConfigMaps](../configmaps).
- `spec.delivery` is used to configure event delivery options. Event delivery options specify what happens to an event that fails to be delivered to an event sink. For more information, see the documentation on [broker event delivery](../broker-event-delivery).

0 comments on commit 1b74ec3

Please sign in to comment.