Added delivery options to broker create

[vyasgun]

Description

Added delivery options to kn broker create

Changes

• Added --dl-sink, --timeout, --backoff-policy, backoff-delay, retry-after-max, --retry flags
• Validation is on the server side for the values
• Added unit test cases

Reference

Fixes #1557

[knative-prow]

@vyasgun: 8 warnings.

In response to this:

Description

Added delivery options to kn broker create

Changes

• Added --dl-sink, --timeout, --backoff-policy, backoff-delay, retry-after-max, --retry flags
• Validation is on the server side for the values
• Added unit test cases

Reference

Fixes #1557

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1670 (d087400) into main (736c7c2) will increase coverage by 0.21%.
The diff coverage is 92.71%.

@@            Coverage Diff             @@
##             main    #1670      +/-   ##
==========================================
+ Coverage   79.48%   79.70%   +0.21%     
==========================================
  Files         171      173       +2     
  Lines       12963    13173     +210     
==========================================
+ Hits        10304    10499     +195     
- Misses       1941     1951      +10     
- Partials      718      723       +5     

Impacted Files	Coverage Δ
pkg/kn/commands/broker/create.go	69.64% <70.00%> (-1.41%)	⬇️
pkg/kn/commands/broker/update.go	86.36% <86.36%> (ø)
pkg/eventing/v1/client.go	91.00% <100.00%> (+3.73%)	⬆️
pkg/eventing/v1/client_mock.go	92.75% <100.00%> (+0.81%)	⬆️
pkg/kn/commands/broker/broker.go	100.00% <100.00%> (ø)
pkg/kn/commands/broker/delivery_option_flags.go	100.00% <100.00%> (ø)
pkg/kn/commands/trigger/update_flags.go	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736c7c2...d087400. Read the comment docs.

[dsimansk]

Added a few comments around coverage and help messages, but otherwise looks OK.

[dsimansk]

Added a short comment about validation.

There's another angle of this change I haven't noticed at first. Originally broker command groups didn't include update. There wasn't no options to modify, except from create/delete flow. However, it should be added probably with this addition flags.

[dsimansk]

@vyasgun wrt my previous comment. IMO we can merge this PR and add broker update afterwards. Let me know what would you prefer. Otherwise looks ready to me.

[vyasgun]

@dsimansk Sorry about the delay. I just added the update command to this PR.

[dsimansk]

/test all

[vyasgun]

/retest

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: vyasgun / name: Gunjan Vyas (2e86c38, b99bb3d, 24ffca9, c2eaef0, c1da8d0, a1ed6be, d087400)

[dsimansk]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment