Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delivery options for "kn broker create" #1557

Closed
Tracked by #1581
rhuss opened this issue Jan 4, 2022 · 0 comments · Fixed by #1670
Closed
Tracked by #1581

Add delivery options for "kn broker create" #1557

rhuss opened this issue Jan 4, 2022 · 0 comments · Fixed by #1670
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@rhuss
Copy link
Contributor

rhuss commented Jan 4, 2022

Feature request

Actually, the support for broker options is quite limited, only the broker class can be currently specified, but none of the delivery options that are described in https://github.com/knative/eventing/blob/5e3183b552cabe35ae1015fa1baff5cd67c0b7cf/pkg/apis/duck/v1/delivery_types.go#L31-L84

These options are independent of the broker implementation and can be typed (.e.g --dl-sink). This is different from #1525 where a reference to an implementation-specific configuration should be able to add.

Use case

Creating a broker with delivery options that are different from the default values.

UI Example

The following options are proposals, the detailed naming is up to discussion:

--dl-sink <sink reference>              Reference to a sink for delivering events that can not be sent
--retry <retries>.                      Number of retries before sending the event to a dead-letter sink
--timeout <duration>                    Timeout for a single request
--backoff-policy  <policy>              Backoff policy for retries, either "linear" or "exponential"
--backoff-delay <duration>              Based delay between retries
--retry-after-max <duration>            Upper bound for a duration specified in an "Retry-After" header (experimental)
@rhuss rhuss added kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage) labels Jan 4, 2022
@rhuss rhuss mentioned this issue Jan 27, 2022
2 tasks
@dsimansk dsimansk added this to the 1.5 (0.32) milestone May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants