Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully qualified test images #1307

Merged
merged 7 commits into from
May 10, 2021
Merged

Fully qualified test images #1307

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a540348
Use fully qualified image references in helloworld Dockerfile
mgencur May 10, 2021
36d3a95
TMP: Run tekton tests in pre-submit
mgencur May 10, 2021
b7ad15e
TMP: Use mgencurs fork so that buildah uses the updated Dockerfile
mgencur May 10, 2021
35694f0
TMP: Fix running in pre-submit
mgencur May 10, 2021
268776d
Revert "TMP: Fix running in pre-submit"
mgencur May 10, 2021
d6c29b5
Revert "TMP: Use mgencurs fork so that buildah uses the updated Docke…
mgencur May 10, 2021
b5809bc
Revert "TMP: Run tekton tests in pre-submit"
mgencur May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_images/helloworld/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Use the official Golang image to create a build artifact.
# This is based on Debian and sets the GOPATH to /go.
# https://hub.docker.com/_/golang
FROM golang:1.13 as builder
FROM docker.io/library/golang:1.13 as builder

# Create and change to the app directory.
WORKDIR /app
Expand All @@ -15,7 +15,7 @@ RUN CGO_ENABLED=0 GOOS=linux go build -v -o server
# Use the official Alpine image for a lean production container.
# https://hub.docker.com/_/alpine
# https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds
FROM alpine:3
FROM docker.io/library/alpine:3
RUN apk add --no-cache ca-certificates

# Copy the binary to the production image from the builder stage.
Expand Down