Fully qualified test images #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/S
* remove this when the tekton tests pass
mgencur
force-pushed
the
fully_qualified_test_images
branch
from
62d9c55
to
36d3a95
Compare
|
/test all |
|
The Tekton tests passed in the previous run: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_client/1307/pull-knative-client-integration-tests/1391687517249474560 |
knative-prow-robot
added
size/XS
mgencur
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This was referenced May 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use fully qualified names for images in the Docker file.
Changes
Reference
Fixes #1308