Making a toReference public to enable reuse from kn-plugins

[cardil]

Description

Moving a toReference to a public package, so that is it possible to invoke it, from kn plugins.

Changes

• Move toReference function to knative.dev/client/pkg/util.ToTrackerReference
• Move parseSelector function to knative.dev/client/pkg/util.ParseSelector

Reference

Fixes #1202

[knative-prow-robot]

@cardil: 0 warnings.

In response to this:

Description

Moving a toReference to a public package, so that is it possible to invoke it, from kn plugins.

Changes

• Move toReference function to knative.dev/client/pkg/util.ToTrackerReference
• Move parseSelector function to knative.dev/client/pkg/util.ParseSelector

Reference

Fixes #1202

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/source/binding/binding.go	57.4%	50.0%	-7.4
pkg/util/parsing_helper.go	86.8%	90.7%	3.9

[cardil]

/retest

[maximilien]

I like the idea and we definitely have every more functions to expose for plugins. However, we had discussed to move all these to the lib/* directory instead of leaving them in the pkg/* So perhaps it makes sense to create a lib/util package and move things there? WDYT?

[cardil]

IDT, if I'm on board with such move. It seems to me like an affront to Golang standards. pkg directory is a Golang standard for code for external use - see: https://github.com/golang-standards/project-layout#pkg

Library code that's ok to use by external applications (e.g., /pkg/mypubliclib)

Internal code should be placed in internal directory.

[rhuss]

Thanks, looks good to me ! We might move this code again later when we do a larger refactoring of shared code though, but for now this is fine for me.

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhuss]

IDT, if I'm on board with such move. It seems to me like an affront to Golang standards. pkg directory is a Golang standard for code for external use - see: https://github.com/golang-standards/project-layout#pkg

Then we did it all wrong until know as we definitely added for-internal-use-only code into this package already. Thanks for the heads up though, we will take the golang recommendations into account when we move around the code into a shared repository.

In order to unblock your work, let's merge this PR and fix that later with the bigger move.