Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use toReference method from outside, in ex. kn plugins #1202

Closed
cardil opened this issue Jan 25, 2021 · 3 comments · Fixed by #1203
Closed

Allow to use toReference method from outside, in ex. kn plugins #1202

cardil opened this issue Jan 25, 2021 · 3 comments · Fixed by #1203
Assignees

Comments

@cardil
Copy link
Contributor

cardil commented Jan 25, 2021

func toReference(subjectArg string, namespace string) (*tracker.Reference, error) {

Writing a kn-event plugin I wanted to parse the addressable in the same way as it is parsed in kn source binding --subject option. To be able to do it, this function needs to be moved to a public place. Maybe knative.dev/client/pkg/util is a good place?

@cardil cardil changed the title Allow to use toReference method from outside - kn plugins Allow to use toReference method from outside, in ex. kn plugins Jan 25, 2021
@cardil
Copy link
Contributor Author

cardil commented Jan 25, 2021

/assign

@rhuss
Copy link
Contributor

rhuss commented Jan 25, 2021

@cardil How urgent is it ? I'm asking because I'm on the way (albeit slowly) to move shared code into a dedicated repository to support reuse and break cyclic dependencies --> #1039

It might still take a bit, but that will the eventual location where we should put the parsing code.

@cardil
Copy link
Contributor Author

cardil commented Jan 25, 2021

I wanted that to finish my kn-event poc. Either way this method needs to be public in order to enable reuse.

So, answering your question. I would like to do it as soon as possible. Than, I'm happy to follow up when the code gets transferred to other repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants