Create broker object with spec.config pointer

[matzew]

Feature request

There is currently no option to use kn to create a broker and provide config parts (e.g. ponting to a ConfigMap or an other resource)

Something like below needs to be still created using k apply... :

apiVersion: eventing.knative.dev/v1
kind: Broker
metadata:
  annotations:
    eventing.knative.dev/broker.class: Kafka
  name: my-kafka-broker
spec:
  config:
    apiVersion: v1
    kind: ConfigMap
    name: kafka-broker-config
    namespace: knative-eventing

Use case

UI Example

[rhuss]

the config: field can point to any object ? Would it be good enough that kn supports only ConfigMaps as references ? That would make the UI much easier (e.g. --config kafka-broker-config)

[matzew]

It;s a duck, and can be anything:
https://github.com/knative/eventing/blob/main/pkg/apis/eventing/v1/broker_types.go#L71-L75

As the Rabbit impl goes, it leverages their own CRDs:
https://github.com/knative-sandbox/eventing-rabbitmq/tree/main/samples/broker/dlq#create-the-rabbitmq-broker

e.g.:

...
  spec:
    config:
      apiVersion: rabbitmq.com/v1beta1
      kind: RabbitmqCluster
      name: rokn
...

[rhuss]

Yeah, I know it can be anything. We can support the full coordinates combo, but if ConfigMap is a commonly used choice, then we could also add a shortcut for people that need a configmap. But from your comment, I infer that ConfigMaps are as common as other objects, so having a --config rokn:rabbitmq.com/v1beta1:RabbitmqCluster:namespace and --config kafka-broker-config:v1:ConfigMap:knative-eventing is it then (and we don't add a --config-map kafka-broker-config as shortcut)

[matzew]

sounds good to me, since CMs are „common“ use

On Mon 13. Dec 2021 at 20:43, Roland Huß ***@***.***> wrote: Yeah, I know it can be anything. We can support the full coordinates combo, but if ConfigMap is a *commonly* used choice, then we could also add a shortcut for people that need a configmap. But from your comment, I infer that ConfigMaps are as common as other objects, so having a --config rokn:rabbitmq.com/v1beta1:RabbitmqCluster:namespace and --config kafka-broker-config:v1:ConfigMap:knative-eventing is it then (and we don't add a --config-map kafka-broker-config as shortcut) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1525 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGPTTT3R445ZLP4BDCMQ3UQZEHVANCNFSM5IMM6L7Q> .

-- Sent from Gmail Mobile

[rhuss]

So, let us add this config option but also think about adding the more advanced, generic options that apply to every broker implementation.

[dsimansk]

@matzew @pierDipi FYI if you get a chance to try and test --broker-config in kn >=1.6.