Skip to content
This repository was archived by the owner on Sep 5, 2019. It is now read-only.

Use library.sh from prow-tests image, instead of yet another copy of it#272

Merged
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:bye-library-sh
Jul 20, 2018
Merged

Use library.sh from prow-tests image, instead of yet another copy of it#272
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:bye-library-sh

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

library.sh in prow-tests image was implemented by knative/test-infra#4

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

`library.sh` in prow-tests image was implemented by knative/test-infra#4
@adrcunha
Copy link
Copy Markdown
Contributor Author

Note that integration tests won't pass until #271 is merged.

Copy link
Copy Markdown
Contributor

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrcunha
Copy link
Copy Markdown
Contributor Author

/retest

@google-prow-robot google-prow-robot merged commit d26ace1 into knative:master Jul 20, 2018
@adrcunha adrcunha deleted the bye-library-sh branch July 21, 2018 08:06
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
…it (knative#272)

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

`library.sh` in prow-tests image was implemented by knative/test-infra#4
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
…it (knative#272)

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

`library.sh` in prow-tests image was implemented by knative/test-infra#4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants