This repository was archived by the owner on Sep 5, 2019. It is now read-only.
Use e2e-tests.sh helper from prow-tests image#271
Merged
google-prow-robot merged 2 commits intoknative:masterfrom Jul 20, 2018
adrcunha:simpler-e2e
Merged
Use e2e-tests.sh helper from prow-tests image#271google-prow-robot merged 2 commits intoknative:masterfrom adrcunha:simpler-e2e
google-prow-robot merged 2 commits intoknative:masterfrom
adrcunha:simpler-e2e
Conversation
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `e2e-tests.sh` helper was implemented by knative/test-infra#17
imjasonh
reviewed
Jul 20, 2018
Contributor
imjasonh
left a comment
imjasonh
left a comment
There was a problem hiding this comment.
Delete all the code! \o/
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 11, 2018
* Fix SSH keys workaround for kubetest Create the ~/.ssh dir if it doesn't exist, don't assume it always exist. Backported from knative/test-infra#151. * Rename //tests to //test to keep naming uniform across the repos Backported from #253. * Use the latest GKE for integration tests Backported from #271. * Fix authentication for test clusters Instead of relying on default options, use basic authentication for test cluster. Also make `acquire_cluster_admin_role()` handle auth through certificates, since it's used also on deployment. Backport of knative/test-infra#115. * Use new valid deploy key, delete old key Because the old private key was in the public repo, GitHub would periodically disable the key, breaking integration tests, and org owners would get spammed with security alerts whenever the repo was forked. This is a new deploy key with read-only access to the repo, and since the private key matter is only included base64'ed in `0-secret.yaml`, GitHub should not alert on it. Backported from #298.
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Use e2e-tests.sh helper from prow-tests image We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `e2e-tests.sh` helper was implemented by knative/test-infra#17 * Add missing KO_DOCKER_REPO export
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Use e2e-tests.sh helper from prow-tests image We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `e2e-tests.sh` helper was implemented by knative/test-infra#17 * Add missing KO_DOCKER_REPO export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.
e2e-tests.shhelper was implemented by knative/test-infra#17