Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.17] Fix test image upload #4230

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #4228

NONE

Copy link

knative-prow bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from aliok and matzew January 24, 2025 08:55
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.33%. Comparing base (badf666) to head (548c4d2).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.17    #4230      +/-   ##
================================================
- Coverage         47.34%   47.33%   -0.02%     
================================================
  Files               270      270              
  Lines             19011    19011              
================================================
- Hits               9001     8998       -3     
- Misses             9298     9300       +2     
- Partials            712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor

Duplicate of #4229

/close

@knative-prow knative-prow bot closed this Jan 24, 2025
Copy link

knative-prow bot commented Jan 24, 2025

@dsimansk: Closed this PR.

In response to this:

Duplicate of #4229

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants