Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test image upload #4228

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Jan 23, 2025

Fixes #

Proposed Changes

  • Fix test image upload

This is on pair with Eventing core repository script. We are now exporting KO_FLAGS from knative.dev/hack. However, the default is KO_FLAGS=-P --platform=all. The -P option is a culprit in this case of building test images, because it preservers import path. Therefore we see image pull errors in release job. Because of the fact that expected image URLs are different, affected by KO_FLAGS.

➜  eventing-kafka-broker git:(pr/fix-test-images) ko resolve --tags latest -RBf vendor/knative.dev/eventing/test/test_images/recordevents
2025/01/23 22:44:39 Using base gcr.io/distroless/static:nonroot@sha256:6ec5aa99dc335666e79dc64e4a6c8b89c33a543a1967f20d360922a80dd21f02 for knative.dev/eventing/test/test_images/recordevents
2025/01/23 22:44:41 Building knative.dev/eventing/test/test_images/recordevents for linux/amd64
2025/01/23 22:45:02 Publishing quay.io/dsimansk/recordevents:latest
Error: error processing import paths in "vendor/knative.dev/eventing/test/test_images/recordevents/pod.yaml": error resolving image references: writing sbom: HEAD https://quay.io/v2/dsimansk/recordevents/manifests/sha256-d49821d1e8064024f21870a652c7936eaaf5d1bcd964bb78efb7d7273a9e2c78.sbom: unexpected status code 401 Unauthorized (HEAD responses have no body, use GET for details)
➜  eventing-kafka-broker git:(pr/fix-test-images) ko resolve -P --platform=all --tags latest -RBf vendor/knative.dev/eventing/test/test_images/recordevents
2025/01/23 22:45:09 Using base gcr.io/distroless/static:nonroot@sha256:6ec5aa99dc335666e79dc64e4a6c8b89c33a543a1967f20d360922a80dd21f02 for knative.dev/eventing/test/test_images/recordevents
2025/01/23 22:45:10 Building knative.dev/eventing/test/test_images/recordevents for linux/amd64
2025/01/23 22:45:11 Building knative.dev/eventing/test/test_images/recordevents for linux/arm64/v8
2025/01/23 22:45:11 Building knative.dev/eventing/test/test_images/recordevents for linux/s390x
2025/01/23 22:45:11 Building knative.dev/eventing/test/test_images/recordevents for linux/ppc64le
2025/01/23 22:45:12 Building knative.dev/eventing/test/test_images/recordevents for linux/arm/v7
2025/01/23 22:46:12 Publishing quay.io/dsimansk/knative.dev/eventing/test/test_images/recordevents:latest
Error: error processing import paths in "vendor/knative.dev/eventing/test/test_images/recordevents/pod.yaml": error resolving image references: writing sbom: HEAD https://quay.io/v2/dsimansk/knative.dev/eventing/test/test_images/recordevents/manifests/sha256-66253a3e5f93a6cdef418919ad0be7e92e3dad1b57d288db8857114b7b849281.sbom: unexpected status code 401 Unauthorized (HEAD responses have no body, use GET for details)

https://github.com/knative/eventing/blob/main/test/upload-test-images.sh

Release Note

NONE

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2025
@dsimansk
Copy link
Contributor Author

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo January 23, 2025 21:50
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.33%. Comparing base (badf666) to head (f8c0789).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4228      +/-   ##
==========================================
- Coverage   47.34%   47.33%   -0.02%     
==========================================
  Files         270      270              
  Lines       19011    19011              
==========================================
- Hits         9001     8998       -3     
- Misses       9298     9300       +2     
- Partials      712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor Author

/retest

1 similar comment
@dsimansk
Copy link
Contributor Author

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

knative-prow bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3f9f40c into knative-extensions:main Jan 24, 2025
30 of 33 checks passed
@knative-prow-robot
Copy link
Contributor

@dsimansk: new pull request created: #4230

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants