-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test image upload #4228
Fix test image upload #4228
Conversation
/cherry-pick release-1.17 |
@dsimansk: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4228 +/- ##
==========================================
- Coverage 47.34% 47.33% -0.02%
==========================================
Files 270 270
Lines 19011 19011
==========================================
- Hits 9001 8998 -3
- Misses 9298 9300 +2
- Partials 712 713 +1 ☔ View full report in Codecov by Sentry. |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3f9f40c
into
knative-extensions:main
@dsimansk: new pull request created: #4230 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #
Proposed Changes
This is on pair with Eventing core repository script. We are now exporting KO_FLAGS from knative.dev/hack. However, the default is
KO_FLAGS=-P --platform=all
. The-P
option is a culprit in this case of building test images, because it preservers import path. Therefore we see image pull errors in release job. Because of the fact that expected image URLs are different, affected byKO_FLAGS
.https://github.com/knative/eventing/blob/main/test/upload-test-images.sh
Release Note