Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Fix Tests #990

Merged
merged 1 commit into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion create_k2_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ echo "Running $name"
# Run the engine
set +e
echo "Using $out_dir as output directory"
go run ./cmd/k2 up \
go run ./cmd/klotho up \
-n=3 \
--state-directory "$out_dir" \
"$infrapy" > $out_dir/out.log 2> $out_dir/err.log
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"iam:DeleteRole*",
"iam:GetRole*",
"iam:List*",
"iam:PassRole",
"iam:PutRole*",
"iam:TagRole",
"iam:UntagRole",
Expand Down
1 change: 1 addition & 0 deletions pkg/engine/testdata/lambda_code.deployment-policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"iam:DeleteRole*",
"iam:GetRole*",
"iam:List*",
"iam:PassRole",
"iam:PutRole*",
"iam:TagRole",
"iam:UntagRole",
Expand Down
4 changes: 2 additions & 2 deletions pkg/k2/testdata/bucket_ro/my-bucket.resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ resources:
RESOURCE_NAME: my-bucket
edges:
outputs:
Bucket:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to outputs are suspicious - is there some nondeterminism here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very possible, but didn't investigate too deeply

ref: aws:s3_bucket:my-bucket#Bucket
BucketArn:
ref: aws:s3_bucket:my-bucket#Arn
BucketRegionalDomainName:
ref: aws:s3_bucket:my-bucket#BucketRegionalDomainName
Bucket:
ref: aws:s3_bucket:my-bucket#Bucket
4 changes: 2 additions & 2 deletions pkg/k2/testdata/function/zip-func.resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ edges:
aws:iam_role:zip-func-function-ExecutionRole -> aws:s3_bucket:my-bucket:
connection_type: readonly
outputs:
FunctionArn:
ref: aws:lambda_function:zip-func-function#Arn
FunctionName:
ref: aws:lambda_function:zip-func-function#FunctionName
FunctionArn:
ref: aws:lambda_function:zip-func-function#Arn
Loading