Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests #990

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix Tests #990

merged 1 commit into from
Aug 14, 2024

Conversation

atorres-klo
Copy link
Contributor

fixed path for create_k2_test.sh, updated some testdata

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

@@ -8,9 +8,9 @@ resources:
RESOURCE_NAME: my-bucket
edges:
outputs:
Bucket:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to outputs are suspicious - is there some nondeterminism here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very possible, but didn't investigate too deeply

@atorres-klo atorres-klo merged commit e1b3124 into main Aug 14, 2024
6 checks passed
@atorres-klo atorres-klo deleted the fix-tests branch August 14, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants