Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

allow null to be value and set as empty array #73

Merged
merged 1 commit into from
Jan 12, 2023
Merged

allow null to be value and set as empty array #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/infra/pulumi_aws/iac/eks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export interface EksExecUnit {
export interface HelmChart {
Name: string
Directory: string
Values: Value[]
Values: Value[] | null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you specifically want null, or is undefined okay?

If undefined is okay, then I think the more typescripty way to do this would be:

Suggested change
Values: Value[] | null
Values?: Value[]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go embed is rendering it to null, so in this case we would specifically want null. Figured its easier to make a 2 line change here than muck around with the go templating stuff

}

interface FargateProfileSelector {
Expand Down Expand Up @@ -385,7 +385,7 @@ export class Eks {
this.setupExecUnit(lib, unit)
}
for (const chart of charts) {
this.setupKlothoHelmChart(lib, chart.Name, chart.Values)
this.setupKlothoHelmChart(lib, chart.Name, chart.Values || [])
}
}

Expand Down