-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow null to be value and set as empty array #73
Conversation
@@ -53,7 +53,7 @@ export interface EksExecUnit { | |||
export interface HelmChart { | |||
Name: string | |||
Directory: string | |||
Values: Value[] | |||
Values: Value[] | null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you specifically want null
, or is undefined
okay?
If undefined
is okay, then I think the more typescripty way to do this would be:
Values: Value[] | null | |
Values?: Value[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go embed is rendering it to null, so in this case we would specifically want null. Figured its easier to make a 2 line change here than muck around with the go templating stuff
|
fixed a bug introduced by model reworking
• Does any part of it require special attention?
• Does it relate to or fix any issue?
We hit this bug during the komodor sync. Essentially for any helm pass through where they are deploying a fully owned chart, we dont have any values we need to substitute in after rendering the helm chart. We expected go embed to render the empty array as [] but its rendering it as null. So if we get a null we will just flip it to []
downloaded redis helm chart and tested passthrough using that. Deployed fine
Standard checks