This repository was archived by the owner on Mar 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
cleanups to "go generate" #166
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,12 @@ | ||
/node_modules/ | ||
dispatcher_fargate.js.tmpl | ||
dispatcher_lambda.js.tmpl | ||
emitter.js.tmpl | ||
fs.js.tmpl | ||
keyvalue.js.tmpl | ||
orm.js.tmpl | ||
proxy_eks.js.tmpl | ||
proxy_fargate.js.tmpl | ||
redis_cluster.js.tmpl | ||
redis_node.js.tmpl | ||
secret.js.tmpl | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,13 +6,18 @@ if [ 'Darwin' = "$(uname -s)" ]; then | |
fi | ||
|
||
npm install | ||
|
||
echo "$*" | jq -R '. | split(" ") | map("_" + . + ".ts") | {extends: "./tsconfig.json", include: .}' > tmp_tsconfig.json | ||
npx tsc --project tmp_tsconfig.json | ||
rm tmp_tsconfig.json | ||
|
||
for var in "$@" | ||
do | ||
echo '{"extends": "./tsconfig.json", "include": ["'_${var}.ts'"]}' > tmp_tsconfig.json | ||
tsc --project tmp_tsconfig.json | ||
rm tmp_tsconfig.json | ||
|
||
mv _${var}.js ${var}.js.tmpl | ||
ksed 's://TMPL ::g' ${var}.js.tmpl | ||
ksed 's://TMPL ::g' ${var}.js.tmpl | ||
echo "generated ${var}.js.tmpl" | ||
echo ${var}.js.tmpl >> .gitignore | ||
done | ||
|
||
sort -u .gitignore > gitignore-tmp | ||
mv gitignore-tmp .gitignore | ||
Comment on lines
+22
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clever, I like this a lot. |
40 changes: 0 additions & 40 deletions
40
pkg/lang/javascript/aws_runtime/dispatcher_fargate.js.tmpl
This file was deleted.
Oops, something went wrong.
124 changes: 0 additions & 124 deletions
124
pkg/lang/javascript/aws_runtime/dispatcher_lambda.js.tmpl
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ignore checking these in? we dont have .js files for all of them so we need some of these checked in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which ones don't we have
.ts
files for? I actually even create the changes to this file manually; they're all from the bash script's changes to add the generated files to this ignore.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i guess this list doesnt include the ones which we dont have ts files for