cleanups to "go generate" #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't check in the generated files; instead, add them to a local gitignore - use "npx tsc" rather than "tsc". This means people don't need tsc globally installed, plus it ensures we all use the same version. - only invoke tsc once, to save some time
Comment on lines
1
to
+12
| /node_modules/ | ||
| dispatcher_fargate.js.tmpl | ||
| dispatcher_lambda.js.tmpl | ||
| emitter.js.tmpl | ||
| fs.js.tmpl | ||
| keyvalue.js.tmpl | ||
| orm.js.tmpl | ||
| proxy_eks.js.tmpl | ||
| proxy_fargate.js.tmpl | ||
| redis_cluster.js.tmpl | ||
| redis_node.js.tmpl | ||
| secret.js.tmpl |
There was a problem hiding this comment.
why ignore checking these in? we dont have .js files for all of them so we need some of these checked in
There was a problem hiding this comment.
Which ones don't we have .ts files for? I actually even create the changes to this file manually; they're all from the bash script's changes to add the generated files to this ignore.
There was a problem hiding this comment.
oh i guess this list doesnt include the ones which we dont have ts files for
jhsinger-klotho
approved these changes
Jan 31, 2023
gordon-klotho
approved these changes
Jan 31, 2023
Comment on lines
+22
to
+23
| sort -u .gitignore > gitignore-tmp | ||
| mv gitignore-tmp .gitignore |
There was a problem hiding this comment.
Clever, I like this a lot.
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting this out on spec; if people don't like it, I'm happy to withdraw it. My motivation is that I keep editing the wrong file and/or forgetting which I should edit, and I'm happier if my IDE reminds me which one is generated and which one is committed.
Changes in this PR:
npx tscrather thantsc. This means people don't need tsc globally installed, plus it ensures we all use the same version.tsconce, to save some time (on my machine, it broughtgo generate ./...down from ~10 seconds to ~3).This does have one tradeoff, which is that you need to run
go generate ./...at least once before you build. In particular, this means that I had to add that command to the integ test runner. That's arguably a bit less convenient and a bit more safe (in terms of not compiling old code that someone forgot to generate), so whether it's good or bad in net is up for interpretation.Standard checks
md5sum *inklotho/pkg/lang/[python|javascript]/aws_runtime(on main, vs on this branch aftergo generate), and confirmed that they're the same other than the bash scriptsgo generate ./...will fix it